Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify emails to show mark weights in event-emails #3299

Merged
merged 2 commits into from
Oct 23, 2024
Merged

modify emails to show mark weights in event-emails #3299

merged 2 commits into from
Oct 23, 2024

Conversation

madsab
Copy link
Contributor

@madsab madsab commented Sep 17, 2024

Description of changes

  • [MOD] Show how many marks were given to users who didn't attend event in committee email after mark-rules has been changed.

Code Checklist

  • I have added tests
  • I have provided documentation

@madsab madsab force-pushed the change-event-comitee-mark-mail branch from 1c03f70 to ccb7313 Compare September 18, 2024 00:12
@madsab madsab force-pushed the change-event-comitee-mark-mail branch from 2bf945f to e4867d6 Compare September 18, 2024 07:30
henrikhorluck
henrikhorluck requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@henrikhorluck henrikhorluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denne PR-en burde fikse dette for all automatisert kommunikasjon mot brukere. Pr. nå fikser den kun meldingen til komiteen, men fikser ikke ordbruk i meldinger til brukere som får de faktiske prikk(ene)

@madsab madsab changed the title mod: message in event-comitee marks email change message in event-comitee marks email Oct 9, 2024
@madsab madsab force-pushed the change-event-comitee-mark-mail branch from edc8fd7 to 364590a Compare October 9, 2024 18:10
@madsab madsab changed the title change message in event-comitee marks email modify emails to show mark weights in event-emails Oct 9, 2024
@henrikhorluck henrikhorluck added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 5a74842 Oct 23, 2024
7 of 8 checks passed
@henrikhorluck henrikhorluck deleted the change-event-comitee-mark-mail branch October 23, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikhorluck henrikhorluck henrikhorluck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsab @henrikhorluck