-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #3017
Merged
Merged
Update dependencies #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
henrikhorluck
commented
Oct 4, 2023
- Upgrade to python 3.11
- Upgrade pre-commit setup
- Prep for django 4.0 by removing direct pytz usage
- Upgrade most Python packages
- Does not upgrade other dependencies, might not actually work in isolation
- Django 4.0 changes the default timezone implementation to be zoneinfo from the standard library, instead of pytz, we can therefore remove it as a direct dependency.
henrikhorluck
force-pushed
the
chore/keep-up-to-date
branch
from
October 4, 2023 10:42
b9cf1e8
to
cd9873e
Compare
Codecov Report
@@ Coverage Diff @@
## main #3017 +/- ##
==========================================
+ Coverage 78.66% 78.72% +0.05%
==========================================
Files 338 338
Lines 14940 15006 +66
==========================================
+ Hits 11753 11813 +60
- Misses 3187 3193 +6
|
henrikhorluck
force-pushed
the
chore/keep-up-to-date
branch
from
October 5, 2023 20:42
a55d39c
to
9a64783
Compare
henrikhorluck
force-pushed
the
chore/keep-up-to-date
branch
from
October 13, 2023 19:53
98be25d
to
57578ee
Compare
henrikskog
approved these changes
Oct 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 🚀
- Use npm instead of yarn 1, I don't have a strong opinion here and can split it out/revert it - This removes a lot of the DX for building the frontend locally, but noone has used than in a long while, and it is a lot less work to remove it than figure out how to get it properly working at this point. - This probably requires additional changes before prod deploy works, and upgrades linting, but does not change any code to make it pass CI
- 'Urls' is just a global variable injected through Django-templates, there is a js-library we could use, but that would have be bad for performance since you have to request a .json file at runtime, and probably use async, which is a lot of code-changes.
- Esbuild is less config and dependencies than webpack, this does lose some hot-reloading abilities, but that should be mitigated by using --watch, and esbuild is wildly more performant than webpack - Ideally we would yeet `less` for plain css, but that is a bit more work for now. - We now consequently use LTS node 18 - The usage of `~` is imports in `less` appears to be deprecated (?), they had to be changed for esbuild to work at least. - Creating the webpack-stats.json-build from esbuild's `meta.json` is kinda wacky, we could also just for django-webpack-loader to support `meta.json`, the whole frontend-setup is strange anyways.
- It should only be added if `--no-optional` is used in prod, which it isn't
henrikhorluck
force-pushed
the
chore/keep-up-to-date
branch
from
October 16, 2023 11:28
6e10032
to
62d41f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.