-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make payment price sync on order delete DOT-263 #2978
Conversation
Have not been able to set up the dev-env to test the fix. I would be grateful if someone could test it, and optionally create a test for the order-removal case. |
@henrikskog, ping because you're the issue author |
Codecov Report
@@ Coverage Diff @@
## main #2978 +/- ##
==========================================
+ Coverage 78.60% 78.66% +0.06%
==========================================
Files 338 338
Lines 14939 14940 +1
==========================================
+ Hits 11743 11753 +10
+ Misses 3196 3187 -9
|
DOT-263 Billed for wrong items in webshop
Is the webshop being used? If so this should probably be looked into. From github issue (#2887): There has been multiple bug reports for this. This is the latest one: “Heisann! Det kan virke som problemet med overbetaling om man fjerner en artikkel fra webshop-handlekurven fortsatt ikke er borte 😅 Er en som fjernet en sløyfe når vedkommende skulle kjøpe ølglass og ble alikevell fakturert for sløyfen i stripe, men registrert for kun ølglassene 🙈” To Reproduce
Expected behavior
Screenshots |
Sorry for reviewing so late, but thank you so much for the PR! I ran it locally and as far as I can tell it now syncs correctly. |
4b4cc8b
to
3e40858
Compare
Description of changes
Fix of #2887
Added decorator to make price sync function also when order is deleted, and not only when new order is created.
Otherwise the price shown in UI and price sent to Stripe diverge after order is deleted
Code Checklist