moved email message to & cc names to config file #538
Conversation
Signed-off-by: Jurj-Bogdan <[email protected]>
Signed-off-by: Jurj-Bogdan <[email protected]>
config/autoload/local.php.dist
Outdated
| @@ -47,10 +47,11 @@ return [ | |||
| 'contact' => [ | |||
| 'notification_receivers' => [], | |||
| 'message_receivers' => [ | |||
There was a problem hiding this comment.
I do not like the string 'receiver'.
In email world, the standard string is 'recipients'
At least for me , 'receiver' is confusing
@alexmerlin your opionion ?
There was a problem hiding this comment.
Another idea might be dropping the "contact" key from local.php altogether, as the only part it's used by default is the sendContactMail function in MessageService.php.
That function already uses the config file from dot-mail (mail.global.php) for the "addFrom" method, and that has the to and cc keys available as well.
There was a problem hiding this comment.
Another idea might be dropping the "contact" key from
local.phpaltogether, as the only part it's used by default is thesendContactMailfunction inMessageService.php.That function already uses the config file from dot-mail (mail.global.php) for the "addFrom" method, and that has the
toandcckeys available as well.
Let' discuss tomorrow
as i do not like either the line from MessageService.php
$this->config['contact']['message_receivers']['to'],
$this->config['contact']['message_receivers']['cc'],
There was a problem hiding this comment.
Refactor the below key from local.php.dist
- remove unused key notification_receivers
- use the variable names: recipient, sender
- add a variable for subject and BCC
- for mandatory fields use fallback from maip config ( sender, recipient, subject )
'contact' => [ 'notification_receivers' => [], 'message_receivers' => [ 'to' => [ '[email protected]', ], 'cc' => [ '[email protected]', ], ], ],
|
contact form sender, in general, is platform sender configured in mail.php config file |
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: MarioRadu <[email protected]>
Signed-off-by: Jurj-Bogdan <[email protected]>
Signed-off-by: Jurj-Bogdan <[email protected]>
config/autoload/local.php.dist
Outdated
| 'message_receivers' => [ | ||
| 'subject' => 'Dotkernel Contact', | ||
| 'message_sender' => [ | ||
| 'name' => '', |
There was a problem hiding this comment.
better a variable name like
from_name
config/autoload/local.php.dist
Outdated
| 'subject' => 'Dotkernel Contact', | ||
| 'message_sender' => [ | ||
| 'name' => '', | ||
| 'address' => '', |
There was a problem hiding this comment.
better a variable name like
from_email
|
why there are 19 files commited ? |
Signed-off-by: Jurj-Bogdan <[email protected]>
Because @Jurj-Bogdan must have merged the latest changes from |
|
yup, i rebased this branch to make sure no conflicts exist with the default branch which was updated while this PR was open |
moved the hardcoded "Dotkernel Team" string to a config file.