code improvements

dotkernel · Sep 12, 2024 · 7fa32e1 · 7fa32e1
1 parent 0e0d55b
commit 7fa32e1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/test/ConfigProviderTest.php b/test/ConfigProviderTest.php
@@ -36,7 +36,7 @@ public function testDependenciesHasFactories(): void
         $this->assertArrayHasKey('LogWriterManager', $this->config['dependencies']['factories']);
     }
 
-    public function testDependenciesHasAliases()
+    public function testDependenciesHasAliases(): void
     {
         $this->assertArrayHasKey('aliases', $this->config['dependencies']);
         $this->assertArrayHasKey(FilterPluginManager::class, $this->config['dependencies']['aliases']);

diff --git a/test/LoggerTest.php b/test/LoggerTest.php
@@ -23,7 +23,6 @@
 use function set_exception_handler;
 
 use const E_USER_NOTICE;
-use const PHP_VERSION_ID;
 
 class LoggerTest extends TestCase
 {
@@ -188,11 +187,7 @@ public function testRegisterErrorHandler(): void
 
         Logger::unregisterErrorHandler();
 
-        if (PHP_VERSION_ID < 80000) {
-            $this->assertEquals('Undefined variable: test', $writer->events[0]['message']);
-        } else {
-            $this->assertEquals('Undefined variable $test', $writer->events[0]['message']);
-        }
+        $this->assertEquals('Undefined variable $test', $writer->events[0]['message']);
     }
 
     public function testOptionsWithMock(): void

diff --git a/test/Writer/StreamTest.php b/test/Writer/StreamTest.php
@@ -90,7 +90,7 @@ public function testGetLogSeparator(): void
         $this->assertIsString($this->subject->getLogSeparator());
     }
 
-    public function testShutDown()
+    public function testShutDown(): void
     {
         $this->assertNull($this->subject->shutdown());
     }