-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fastify example standard fetch #3539
base: main
Are you sure you want to change the base?
Conversation
|
Apollo Federation Subgraph Compatibility Results
Learn more: |
💻 Website PreviewThe latest changes are available as preview in: https://81b5cacb.graphql-yoga.pages.dev |
✅ Benchmark Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is good to use @whatwg-node/fetch
.
Thanks to catching this IPV6 bug here, we could fix the issue in whatwg-node/fetch which helped our other tools using @whatwg-node/fetch
Even if this is not a test for whatwg-node/fetch, it is still valuable to use it in our tests.
Also ipv6 is reproduced here during the lockfile upgrade, and fixed after bumping to the patch version;
https://github.com/dotansimha/graphql-yoga/actions/runs/12264473643/job/34218403800
@ardatan Good to note that tradeoff! |
@@ -24201,6 +24198,23 @@ snapshots: | |||
'@swc/[email protected]': | |||
optional: true | |||
|
|||
'@swc/[email protected]': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diff looks weird 🤔
Simplify the Fastify example by using standard fetch. Benefits:
Following this change, I will update the other examples too.