Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disingenuous comparison #3435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

firatoezcan
Copy link

See title, it's a bad look no matter how you turn it to have a comparison where one of the implementations uses a cache and the other libraries dont.

The JIT is fine, but also there it'd be more fair to have a row for apollo-server with jit.

Additionally it'd be best if the implementations dont diverge at all also in the usage if the underlying server because at this point the comparison is completely useless.

But at least with this PR it's not disingenuous anymore and only negligent

Copy link

changeset-bot bot commented Sep 15, 2024

⚠️ No Changeset found

Latest commit: fb9d990

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Urigo
Copy link
Collaborator

Urigo commented Sep 15, 2024

Thank you for flagging @firatoezcan
We have a couple of goals in showing these comparisons:

  1. Compare regular usage of the server (which shows that there Yoga is faster then Apollo)
  2. Show that Yoga can support adding more optimizations easily

There is no disingenuous content here, just showing real results.
Maybe instead of removing information, a better way would be to add the equivalent results for Apollo?
Would you like to help us in doing that?

@firatoezcan
Copy link
Author

It definitely feels disingenuous because there is no even playing ground but let's disagree on the disingenuous part then.

I am planning on doing a more in-depth evaluation in coming weeks for a project. I'll make a note in my planner to return with results.

Usually I was only going to evaluate Bun with Elysia since this is what I use and it's probably faster than anything that's doable with Node so the overhead of either Yoga or Apollo were more interesting for me, but I assume if I already have a few benches that mimic what I would be doing in production, that I could extend those to Fastify/ Hono and Node.js as the runtime as well

Not sure if there are any other popular server frameworks, won't hurt to maybe add express just for people to see that it's slowing them down. Feel free to add a few more, although I think those should be plenty enough.

@Urigo
Copy link
Collaborator

Urigo commented Sep 15, 2024

Ohh it would be awesome to add Bun to these benchmarks!
the more information/frameworks/tools the better!
looking forward to get your results and to work together to make it all public in a way that is most clear and true for the user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants