Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update jwt.mdx - useJWT config field names & options #3415

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

GreenmeisterDavid
Copy link
Contributor

@GreenmeisterDavid GreenmeisterDavid commented Aug 21, 2024

Fix code examples.

useJWT config;

  • lookupLocations -> tokenLookupLocations
  • extendContext: true, -> according to TS this is either a boolean or string, so I assume give it a string to customize the field?

Came across these while implementing this awesome plugin 💚

Fix examples
Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: 4a99c6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GreenmeisterDavid GreenmeisterDavid changed the title Update jwt.mdx docs: update jwt.mdx - field names & options Aug 21, 2024
@GreenmeisterDavid GreenmeisterDavid changed the title docs: update jwt.mdx - field names & options docs: update jwt.mdx - useJWT config field names & options Aug 21, 2024
@ardatan
Copy link
Collaborator

ardatan commented Aug 21, 2024

Thanks for the fix :)

@ardatan ardatan merged commit 1ea798f into dotansimha:main Aug 21, 2024
5 checks passed
Copy link
Contributor

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 414094      ✗ 0     
     data_received................................: 1.7 GB  14 MB/s
     data_sent....................................: 84 MB   697 kB/s
     http_req_blocked.............................: avg=1.5µs    min=1.01µs   med=1.32µs   max=563.6µs  p(90)=1.96µs   p(95)=2.14µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=130.9µs  p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=365.76µs min=219.25µs med=327.78µs max=19.07ms  p(90)=468.79µs p(95)=487.28µs
       { expected_response:true }.................: avg=365.76µs min=219.25µs med=327.78µs max=19.07ms  p(90)=468.79µs p(95)=487.28µs
     ✓ { mode:graphql-jit }.......................: avg=290.62µs min=219.25µs med=269.1µs  max=19.07ms  p(90)=298.47µs p(95)=310.65µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=493.15µs min=405.56µs med=464.87µs max=9.53ms   p(90)=502.52µs p(95)=533.18µs
     ✓ { mode:graphql-response-cache }............: avg=345.46µs min=270.97µs med=326.88µs max=6.1ms    p(90)=355.91µs p(95)=366.73µs
     ✓ { mode:graphql }...........................: avg=369.53µs min=280.2µs  med=336.38µs max=14.05ms  p(90)=380.4µs  p(95)=421.82µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 207047
     http_req_receiving...........................: avg=34.04µs  min=17.4µs   med=33.97µs  max=1.11ms   p(90)=39.33µs  p(95)=41.5µs  
     http_req_sending.............................: avg=8.46µs   min=6.02µs   med=7.44µs   max=512.84µs p(90)=11.05µs  p(95)=11.96µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=323.24µs min=187.45µs med=285.86µs max=18.89ms  p(90)=426.05µs p(95)=442.44µs
     http_reqs....................................: 207047  1725.365428/s
     iteration_duration...........................: avg=574.63µs min=396.11µs med=533.26µs max=19.61ms  p(90)=681.49µs p(95)=704.07µs
     iterations...................................: 207047  1725.365428/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants