Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation and example for usage with express+helmet #2902

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

EmrysMyrddin
Copy link
Collaborator

fixes #2901

@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2023

⚠️ No Changeset found

Latest commit: 0fe7c56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@EmrysMyrddin EmrysMyrddin requested a review from ardatan July 1, 2023 12:47
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 308588      ✗ 0     
     data_received................................: 1.2 GB  10 MB/s
     data_sent....................................: 62 MB   519 kB/s
     http_req_blocked.............................: avg=1.72µs   min=1µs     med=1.5µs   max=948.01µs p(90)=2.1µs   p(95)=2.29µs  
     http_req_connecting..........................: avg=7ns      min=0s      med=0s      max=659.8µs  p(90)=0s      p(95)=0s      
     http_req_duration............................: avg=518.15µs min=265.6µs med=426.8µs max=35ms     p(90)=756µs   p(95)=785.7µs 
       { expected_response:true }.................: avg=518.15µs min=265.6µs med=426.8µs max=35ms     p(90)=756µs   p(95)=785.7µs 
     ✓ { mode:graphql-jit }.......................: avg=383.52µs min=265.6µs med=338.6µs max=21.51ms  p(90)=400.8µs p(95)=428.7µs 
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=823.48µs min=677.5µs med=753.2µs max=25.16ms  p(90)=816.7µs p(95)=909.32µs
     ✓ { mode:graphql-response-cache }............: avg=446.74µs min=314.9µs med=406.8µs max=16.22ms  p(90)=456.3µs p(95)=470.1µs 
     ✓ { mode:graphql }...........................: avg=540.19µs min=396.9µs med=464.7µs max=35ms     p(90)=549.7µs p(95)=652.89µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 154294
     http_req_receiving...........................: avg=30.96µs  min=17.3µs  med=26.8µs  max=9.32ms   p(90)=39µs    p(95)=43µs    
     http_req_sending.............................: avg=13.76µs  min=6.2µs   med=8.4µs   max=4.97ms   p(90)=13.6µs  p(95)=15.4µs  
     http_req_tls_handshaking.....................: avg=0s       min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting.............................: avg=473.42µs min=236.1µs med=387µs   max=33.74ms  p(90)=718.1µs p(95)=741.3µs 
     http_reqs....................................: 154294  1285.756686/s
     iteration_duration...........................: avg=771.98µs min=482.7µs med=676.7µs max=35.47ms  p(90)=1ms     p(95)=1.04ms  
     iterations...................................: 154294  1285.756686/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

💻 Website Preview

The latest changes are available as preview in: https://f75296bc.graphql-yoga.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@EmrysMyrddin EmrysMyrddin merged commit d9dcf67 into main Jul 3, 2023
28 checks passed
@EmrysMyrddin EmrysMyrddin deleted the doc/express-helmet branch July 3, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation to use graphql-yoga and helmet together
2 participants