[resolvers] Ensure __isTypeof is only generated for implementing types (of Interfaces) or Union members
#10283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 61e6158 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eddeee888
changed the title
__isTypeof is only generated for implementing types (of Interfaces) or Union members__isTypeof is only generated for implementing types (of Interfaces) or Union members
2 tasks
eddeee888
commented
Feb 8, 2025
| @@ -679,7 +694,6 @@ export class BaseResolversVisitor< | |||
| protected _hasReferencedResolversUnionTypes = false; | |||
| protected _hasReferencedResolversInterfaceTypes = false; | |||
| protected _resolversUnionTypes: Record<string, string> = {}; | |||
| protected _resolversUnionParentTypes: Record<string, string> = {}; | |||
There was a problem hiding this comment.
This is no longer used, so we can remove it now.
dotansimha
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only implementing types (of Interfaces) or Union members need
__isTypeOfto help pick the right type name for the responses. This PR implements this behaviour by only generating__isTypeOffor said object types.This PR also introduces
_parsedSchemaMetato hold metadata about the schema. This can help with performance and reduces complexity because we only parse through the schema once to collect meta about the types, and use the collected meta for subsequent generation.Note: This is an re-implementation for #10138, because this will be released as a breaking change instead of a new config.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?