Allow more enum configs in client-preset #10158
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client-preset package restricts the allowed configs to improve developer experience, however in monorepo environments it is important that some things work the same across the board. A big example of this is enums, notably having enums defined
as const
and being able to reuse any enums that are shared between client and server🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Description
The client-preset package restricts the allowed configs to improve developer experience, however in monorepo environments it is important that some things work the same across the board. A big example of this is enums, notably having enums defined
as const
and being able to reuse any enums that are shared between client and server.This PR does exactly that, allows passing
enumsAsConst
andenumValues
to the underlying plugin.Related # (issue)
#8993
Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
N/A
How Has This Been Tested?
Literally just add the config options and see the change, I have been using these fields in @ukdanceblue/monorepo for almost a year now without issue.
Test Environment:
@graphql-codegen/...
: client-presetChecklist:
Further comments
N/A