Change apollo-angular imports to named non-namespace imports

[DaSchTour]

Is your feature request related to a problem? Please describe.

Because of this thymikee/jest-preset-angular#963 bug it is not possible to write tests with generated services.

Describe the solution you'd like

Imports for angular-apollo should be changed from import * as Apollo from 'apollo-angular'; to import {Apollo, ...} from 'apollo-angular'

Describe alternatives you've considered

Hacky solutions described in the jest-preset-angular issue, that might have other unknown effects.

[acuevas91]

Is there any update on this issue? Cause this import breaks unit tests and it is annoying... thanks!

[joepvl]

It's probably worth noting that the typescript-apollo-angular plugin was moved to dotanshima/graphql-code-generator-community.

[acuevas91]

But I have seen that the main issues board refers to this repository, do you think we should create this issue in the board you mention? @joepvl

[joepvl]

That would be my guess, as relevant PRs would also be in that repo. In any case, I wouldn't hold my breath for this being implemented by the maintainers. I worked around the issue myself by using the afterOneFileWrite hook to rewrite some of the generated code. It's not exactly pretty though.

[acuevas91]

@joepvl perfect, many thanks for your response! I did not know about this hook, I will take a look!

[gsingh-ut]

I am running into the exact same problem described above.
@acuevas91 Did you end up opening an issue on dotanshima/graphql-code-generator-community ?

[acuevas91]

Nop I did not have time to do it. If so, I will posted it here

[gsingh-ut]

Nop I did not have time to do it. If so, I will posted it here

Thanks for the update. In that case, I will create one and link it here 😄