Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change apollo-angular imports to named non-namespace imports #28

Open
gsingh-ut opened this issue Dec 5, 2022 · 0 comments
Open

Change apollo-angular imports to named non-namespace imports #28

gsingh-ut opened this issue Dec 5, 2022 · 0 comments

Comments

@gsingh-ut
Copy link

Creating a copy of the issue created by @DaSchTour #223 on the older repo.

Is your feature request related to a problem? Please describe.
Because of this thymikee/jest-preset-angular#963 bug, it is not possible to write tests with generated services.

Describe the solution you'd like
Imports for angular-apollo should be changed from import * as Apollo from 'apollo-angular'; to import {Apollo, ...} from 'apollo-angular'

Describe alternatives you've considered

Hacky solutions described in the jest-preset-angular issue like including the generated ts files in tsconfig.spec.json which might have other unknown effects like including too many files which are not required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant