Support merge queue #255
Draft
Support merge queue #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaru-iritani
changed the title
masaru-iritani
commented
Dec 18, 2024
| if (base) { | ||
| core.warning(`'base' input parameter is ignored when action is triggered by pull request event`) | ||
| } | ||
| const pr = github.context.payload.pull_request as PullRequestEvent |
There was a problem hiding this comment.
I guess it may not be working currently...?
Suggested change
| const pr = github.context.payload.pull_request as PullRequestEvent | |
| const pr = github.context.payload as PullRequestEvent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll publish this pull request once confirmed it's good to go by maintainers.
What
This pull request adds a support for
merge_groupevent.Why
Closes #183
Closes #253
Some repositories (including my organization's one) enable the merge queue, where pull requests are queued to be checked sequentially. It's common (I believe) to use the same test workflow for both
pull_requestevent andmerge_groupevent, which is triggered when a change gets into or out of the merge queue.Currently,
paths-filteraction doesn't do anything special for detecting the base commit for a commit in the merge queue. Therefore, if the merge queue has multiple pull requests, the diff may include changes from other pull requests and cause false-positives.Specifying the
baseandrefexplicitly from themerge_groupevent (as shown in #183) can workaround the problem. But it'd be great ifpaths-filtercan handle them by default.This change won't break existing workflows already specifying
refandbaseexplicitly because manual inputs take precedence over commit hashes from the event (unlikepull_requestevents where manual inputs are ignored).