Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the range of supported Ruby and Rails versions #215

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

naitoh
Copy link
Contributor

@naitoh naitoh commented Nov 21, 2024

Ruby 3.3 is out and 2.7, 3.0 has reached the EOL:
https://www.ruby-lang.org/en/downloads/branches/

Also since Rails 6 has been dropped support for and corresponding gemfiles are now dispensable to ci.
https://rubyonrails.org/maintenance

@naitoh naitoh marked this pull request as ready for review November 21, 2024 07:34
@nbulaj
Copy link
Member

nbulaj commented Nov 28, 2024

hey @naitoh , thanks for your contribution, can we please rebase this branch to have all the latest changes in?

Ruby 3.3 is out and 2.7, 3.0 has reached the EOL:
https://www.ruby-lang.org/en/downloads/branches/

Also since Rails 6 has been dropped support for and
corresponding gemfiles are now dispensable to ci.
https://rubyonrails.org/maintenance
@naitoh naitoh force-pushed the update_ruby_and_rails_versions branch from 26a2bea to 94ce857 Compare November 28, 2024 10:25
@naitoh
Copy link
Contributor Author

naitoh commented Nov 28, 2024

can we please rebase this branch to have all the latest changes in?

@nbulaj
OK, I have rebased this branch to include all the latest changes, now.

Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nbulaj nbulaj merged commit 9ecc227 into doorkeeper-gem:master Nov 29, 2024
8 checks passed
@naitoh naitoh deleted the update_ruby_and_rails_versions branch November 29, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants