Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to reuse_access_toke #87

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

yokozawa0701
Copy link
Contributor

resolve #86

Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work only with newest doorkeeper version. We have either change version in the gem spec either add support for old im0lementations as well

@yokozawa0701
Copy link
Contributor Author

@nbulaj

Thanks for your review 😄
I simply add keyword arguments, include_expired, with a default value. The new feature I added is only called when this argument is sent. So I think It is not a problem for doorkeepers with old versions, right?

@nbulaj
Copy link
Member

nbulaj commented Mar 25, 2024

So I think It is not a problem for doorkeepers with old versions, right?

Yeah, I hope so.. Maybe internals are using matching_token_for but since kward has a default I hope it will be OK to use it with old gem versions as well. Thanks!

@nbulaj nbulaj merged commit 16c5e92 into doorkeeper-gem:master Mar 25, 2024
@yokozawa0701 yokozawa0701 deleted the issue-86 branch March 25, 2024 10:54
@yokozawa0701
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgumentError (wrong number of arguments (given 4, expected 3)) when to enable reuse_access_token
2 participants