fix(org): compat with org-modern horizontal rules #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJJ
force-pushed
the
fix-horizontal-rules
branch
from
b5fadff
to
ce4cd3b
Compare
TheJJ
force-pushed
the
fix-horizontal-rules
branch
from
ce4cd3b
to
6168f3c
Compare
|
hey @hlissner! could you please have a look if this is alright to fix this doom themes bug? miniad said in minad/org-modern#59 (comment) that adjustments in org-modern could be made if some knobs are missing there. |
…ations this fixes compatibility with org modern: org-modern fontifies horizontal rules using org-modern-horizontal-rule. doom-themes does so too but using org-meta-line, and has precedence. to resolve this conflict, add a switch to disable doom-themes fontifications.
TheJJ
force-pushed
the
fix-horizontal-rules
branch
from
6168f3c
to
e952cb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org-modernfontifies horizontal rules usingorg-modern-horizontal-rule.doom-themes does so too but using
org-meta-linebeforeorg-moderndoes it.to resolve this conflict, add a switch to disable doom-themes fontifications.
since I introduced a new face, it should not cause any change by default.
Ref: minad/org-modern#59
Ref: minad/org-modern#145