fix: card banner images should not be draggable (toeverything#6098)

donteatfriedrice · Jan 25, 2024 · 2beb067 · 2beb067
1 parent be51e92
commit 2beb067
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/packages/blocks/src/bookmark-block/components/bookmark-card.ts b/packages/blocks/src/bookmark-block/components/bookmark-card.ts
@@ -110,7 +110,11 @@ export class BookmarkCard extends WithDisposable(ShadowlessElement) {
     const titleIcon = loading
       ? LoadingIcon
       : icon
-        ? html`<object type="image/${titleIconType}" data=${icon}>
+        ? html`<object
+            type="image/${titleIconType}"
+            data=${icon}
+            draggable="false"
+          >
             ${WebIcon16}
           </object>`
         : WebIcon16;
@@ -125,7 +129,7 @@ export class BookmarkCard extends WithDisposable(ShadowlessElement) {
 
     const bannerImage =
       !loading && image
-        ? html`<object type="image/webp" data=${image}>
+        ? html`<object type="image/webp" data=${image} draggable="false">
             ${EmbedCardBannerIcon}
           </object>`
         : EmbedCardBannerIcon;

diff --git a/packages/blocks/src/embed-github-block/embed-github-block.ts b/packages/blocks/src/embed-github-block/embed-github-block.ts
@@ -214,7 +214,7 @@ export class EmbedGithubBlockComponent extends EmbedBlockElement<
     const descriptionText = loading ? '' : description;
     const bannerImage =
       !loading && image
-        ? html`<object type="image/webp" data=${image}>
+        ? html`<object type="image/webp" data=${image} draggable="false">
             ${EmbedCardBannerIcon}
           </object>`
         : EmbedCardBannerIcon;

diff --git a/packages/blocks/src/embed-youtube-block/embed-youtube-block.ts b/packages/blocks/src/embed-youtube-block/embed-youtube-block.ts
@@ -207,14 +207,14 @@ export class EmbedYoutubeBlockComponent extends EmbedBlockElement<
     const descriptionText = loading ? '' : description;
     const bannerImage =
       !loading && image
-        ? html`<object type="image/webp" data=${image}>
+        ? html`<object type="image/webp" data=${image} draggable="false">
             ${EmbedCardBannerIcon}
           </object>`
         : EmbedCardBannerIcon;
 
     const creatorImageEl =
       !loading && creatorImage
-        ? html`<object type="image/webp" data=${creatorImage}>
+        ? html`<object type="image/webp" data=${creatorImage} draggable="false">
             ${EmbedCardBannerIcon}
           </object>`
         : nothing;