Skip to content

Commit

Permalink
fix(store): model.created not emit (toeverything#5537)
Browse files Browse the repository at this point in the history
  • Loading branch information
Flrande authored Nov 30, 2023
1 parent 7fc96dc commit 0f858b9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion packages/store/src/workspace/block/block.ts
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ export class Block {
model.keys.includes(p)
) {
this.yBlock.delete(`prop:${p}`);
this.model.propsUpdated.emit({ key: p });
}

return Reflect.deleteProperty(target, p);
Expand Down
1 change: 1 addition & 0 deletions packages/store/src/workspace/page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@ export class Page extends BlockTree {
assertExists(block);
const model = block.model;
model.page = this;
model.created.emit();

const yChildren = yBlock.get('sys:children');
if (yChildren instanceof Y.Array) {
Expand Down

4 comments on commit 0f858b9

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Size Report

Bundles

Entry Size Gzip Brotli
examples/basic 12.8 MB (+275 kB) 2.54 MB (+78.7 kB) 1.59 MB (+61 kB)

Packages

Name Size Gzip Brotli
blocks 1.72 MB (+1.06 kB) 428 kB (-945 B) 322 kB (+362 B)
editor 9.18 kB 3.47 kB 3.05 kB
store 60.4 kB (-113 B) 17.7 kB (-29 B) 15.8 kB (-39 B)
virgo 31.3 kB 8.81 kB 7.91 kB

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Size Report

Bundles

Entry Size Gzip Brotli
examples/basic 12.8 MB 2.54 MB 1.59 MB

Packages

Name Size Gzip Brotli
blocks 1.72 MB 428 kB 322 kB
editor 9.18 kB 3.47 kB 3.05 kB
store 60.4 kB 17.7 kB 15.8 kB
virgo 31.3 kB 8.81 kB 7.91 kB

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Size Report

Bundles

Entry Size Gzip Brotli
examples/basic 12.8 MB 2.54 MB 1.59 MB

Packages

Name Size Gzip Brotli
blocks 1.72 MB 428 kB 322 kB
editor 9.18 kB 3.47 kB 3.05 kB
store 60.4 kB 17.7 kB 15.8 kB
virgo 31.3 kB 8.81 kB 7.91 kB

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Size Report

Bundles

Entry Size Gzip Brotli
examples/basic 12.8 MB 2.54 MB 1.59 MB

Packages

Name Size Gzip Brotli
blocks 1.72 MB 428 kB 322 kB
editor 9.18 kB 3.47 kB 3.05 kB
store 60.4 kB 17.7 kB 15.8 kB
virgo 31.3 kB 8.81 kB 7.91 kB

Please sign in to comment.