Issue CollaboraOnline#43: Explicitly return NULL, to avoid inconsiste…

…nt return points.
donquixote · Nov 8, 2024 · 8f660e9 · 8f660e9
1 parent 6712aff
commit 8f660e9
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/Cool/CoolRequest.php b/src/Cool/CoolRequest.php
@@ -140,36 +140,36 @@ public function getWopiClientURL() {
         $wopi_client_server = $default_config->get('cool')['server'];
         if (!$wopi_client_server) {
             $this->error_code = 201;
-            return;
+            return NULL;
         }
         $wopi_client_server = trim($wopi_client_server);
 
         if (!strStartsWith($wopi_client_server, 'http')) {
             $this->error_code = 204;
-            return;
+            return NULL;
         }
 
         if (!strStartsWith($wopi_client_server, $_HOST_SCHEME . '://')) {
             $this->error_code = 202;
-            return;
+            return NULL;
         }
 
         $discovery = getDiscovery($wopi_client_server);
         if ($discovery === false) {
             $this->error_code = 203;
-            return;
+            return NULL;
         }
 
         $discovery_parsed = simplexml_load_string($discovery);
         if (!$discovery_parsed) {
             $this->error_code = 102;
-            return;
+            return NULL;
         }
 
         $this->wopi_src = strval(getWopiSrcUrl($discovery_parsed, 'text/plain')[0]);
         if (!$this->wopi_src) {
             $this->error_code = 103;
-            return;
+            return NULL;
         }
 
         return $this->wopi_src;