-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Upgrade to prompt_toolkit 2.0 #104
base: master
Are you sure you want to change the base?
[WIP] Upgrade to prompt_toolkit 2.0 #104
Conversation
@jonathanslenders you might want to check #68. tl;dr, this project is deprecated in favor of |
OK. I'll see whether I can send a similar pull request to aws-shell. Thanks for the pointer! |
I don't agree with @jeffbyrnes here. I've fixed them on my end with some minor changes - see #114 |
I mean, it’s… not an opinion of mine; at the time I posted that, the maintainer of SAWS (@donnemartin) appeared to have decided to work with the aws-shell folks & merge the projects (per the issue I referenced). The aws-shell project is also Officially Supported™ by AWS, so that seems like a good thing? Not that they’re doing very much of that. But honestly, you’re right that SAWS has seen more activity; aws-shell hasn’t been updated since Sep 21, 2018, per its project repo. OSS is hard? 🤷♂ |
My bad, I hadn't looked at #68. Personal preference too, but having used aws-shell, I prefer saws. Not sure why that is though :-) |
Going through old issues I’m in, and giving this one a bump to either merge, or close, since it’s > 1 yr old. |
TODO: check the ignore_case parameter.