Add optimize CLI join flags --join-keep-named and --join-keep-meshes
#1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jo-chemla
changed the title
--join-keepNamed and --join-keepMeshes--join-keep-named and --join-keep-meshes
donmccurdy
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Thanks @jo-chemla! I'm open to adding these flags — note that they'll need to be passed through in the command implementation below these flag declarations.
|
🤦 |
|
Should be good to go, tested via Note the defaults are not displayed anymore in the respective help CLIs. |
|
Thanks @jo-chemla! Just as FYI, I think I may rename these flags as
Hm, maybe it just doesn't show defaults whose values are 'false'? Annoying but outside the control of my library at tho moment. 😕
Just curious, is |
|
Thanks for the feedback!
Regarding defaults not printed indeed only those that are true are printed - first I thought this was because the default from code is a constant rather than explicit bool,
And for the C:\Dev\Iconem\glTF-Transform>npm i
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @typescript-eslint/[email protected]
npm warn Found: [email protected]
npm warn node_modules/eslint
npm warn dev eslint@"9.7.0" from the root project
npm warn 4 more (@eslint-community/eslint-utils, eslint-compat-utils, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer eslint@"^8.56.0" from @typescript-eslint/[email protected]
npm warn node_modules/@typescript-eslint/eslint-plugin
npm warn @typescript-eslint/eslint-plugin@"7.18.0" from [email protected]
npm warn node_modules/typescript-eslint
npm warn
npm warn Conflicting peer dependency: [email protected]
npm warn node_modules/eslint
npm warn peer eslint@"^8.56.0" from @typescript-eslint/[email protected]
npm warn node_modules/@typescript-eslint/eslint-plugin
npm warn @typescript-eslint/eslint-plugin@"7.18.0" from [email protected]
npm warn node_modules/typescript-eslint
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @typescript-eslint/[email protected]
npm warn Found: [email protected]
npm warn node_modules/eslint
npm warn dev eslint@"9.7.0" from the root project
npm warn 4 more (@eslint-community/eslint-utils, eslint-compat-utils, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer eslint@"^8.56.0" from @typescript-eslint/[email protected]
npm warn node_modules/@typescript-eslint/parser
npm warn peer @typescript-eslint/parser@"^7.0.0" from @typescript-eslint/[email protected]
npm warn node_modules/@typescript-eslint/eslint-plugin
npm warn 1 more (typescript-eslint)
npm warn
npm warn Conflicting peer dependency: [email protected]
npm warn node_modules/eslint
npm warn peer eslint@"^8.56.0" from @typescript-eslint/[email protected]
npm warn node_modules/@typescript-eslint/parser
npm warn peer @typescript-eslint/parser@"^7.0.0" from @typescript-eslint/[email protected]
npm warn node_modules/@typescript-eslint/eslint-plugin
npm warn 1 more (typescript-eslint)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @typescript-eslint/[email protected]
npm warn Found: [email protected]
npm warn node_modules/eslint
npm warn dev eslint@"9.7.0" from the root project
npm warn 4 more (@eslint-community/eslint-utils, eslint-compat-utils, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer eslint@"^8.56.0" from @typescript-eslint/[email protected]
npm warn node_modules/@typescript-eslint/type-utils
npm warn @typescript-eslint/type-utils@"7.18.0" from @typescript-eslint/[email protected]
npm warn node_modules/@typescript-eslint/eslint-plugin
npm warn
npm warn Conflicting peer dependency: [email protected]
npm warn node_modules/eslint
npm warn peer eslint@"^8.56.0" from @typescript-eslint/[email protected]
npm warn node_modules/@typescript-eslint/type-utils
npm warn @typescript-eslint/type-utils@"7.18.0" from @typescript-eslint/[email protected]
npm warn node_modules/@typescript-eslint/eslint-plugin
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @typescript-eslint/[email protected]
npm warn Found: [email protected]
npm warn node_modules/eslint
npm warn dev eslint@"9.7.0" from the root project
npm warn 4 more (@eslint-community/eslint-utils, eslint-compat-utils, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer eslint@"^8.56.0" from @typescript-eslint/[email protected]
npm warn node_modules/@typescript-eslint/utils
npm warn @typescript-eslint/utils@"7.18.0" from @typescript-eslint/[email protected]
npm warn node_modules/@typescript-eslint/eslint-plugin
npm warn 2 more (@typescript-eslint/type-utils, typescript-eslint)
npm warn
npm warn Conflicting peer dependency: [email protected]
npm warn node_modules/eslint
npm warn peer eslint@"^8.56.0" from @typescript-eslint/[email protected]
npm warn node_modules/@typescript-eslint/utils
npm warn @typescript-eslint/utils@"7.18.0" from @typescript-eslint/[email protected]
npm warn node_modules/@typescript-eslint/eslint-plugin
npm warn 2 more (@typescript-eslint/type-utils, typescript-eslint)
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: [email protected]
npm error Found: [email protected]
npm error node_modules/eslint
npm error dev eslint@"9.7.0" from the root project
npm error peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/[email protected]
npm error node_modules/@eslint-community/eslint-utils
npm error @eslint-community/eslint-utils@"^4.4.0" from @typescript-eslint/[email protected]
npm error node_modules/@typescript-eslint/utils
npm error @typescript-eslint/utils@"7.18.0" from @typescript-eslint/[email protected]
npm error node_modules/@typescript-eslint/eslint-plugin
npm error @typescript-eslint/eslint-plugin@"7.18.0" from [email protected]
npm error node_modules/typescript-eslint
npm error 2 more (@typescript-eslint/type-utils, typescript-eslint)
npm error @eslint-community/eslint-utils@"^4.2.0" from [email protected]
npm error 1 more (eslint-plugin-svelte)
npm error 3 more (eslint-compat-utils, eslint-config-prettier, eslint-plugin-svelte)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^8.56.0" from [email protected]
npm error node_modules/typescript-eslint
npm error dev typescript-eslint@"^7.17.0" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/eslint
npm error peer eslint@"^8.56.0" from [email protected]
npm error node_modules/typescript-eslint
npm error dev typescript-eslint@"^7.17.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error C:\Users\jonathan\AppData\Local\npm-cache\_logs\2024-11-20T07_53_58_297Z-eresolve-report.txt
npm error A complete log of this run can be found in: C:\Users\jonathan\AppData\Local\npm-cache\_logs\2024-11-20T07_53_58_297Z-debug-0.log
|
Ah ok, thanks! I use Yarn, perhaps this is needed since npm presumably isn't reading the |
|
Indeed, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1550
Set default values to false like the current join CLI.