fix: catching exceptions when sending

donderjoekel · Feb 3, 2024 · 325a0e8 · 325a0e8
1 parent 7b87123
commit 325a0e8
Showing 1 changed file with 22 additions and 2 deletions.
diff --git a/src/Mangarr.Stack/Sources/Clients/CustomHttpClient.Get.cs b/src/Mangarr.Stack/Sources/Clients/CustomHttpClient.Get.cs
@@ -108,7 +108,17 @@ public async Task<Result<byte[]>> GetBuffer(string requestUri, CancellationToken
     public async Task<Result<T>> Get<T>(string requestUri, CancellationToken ct = default)
     {
         HttpClient httpClient = CreateClient();
-        using HttpResponseMessage response = await httpClient.SendAsync(CreateGetRequest(requestUri), ct);
+        HttpResponseMessage response;
+
+        try
+        {
+            response = await httpClient.SendAsync(CreateGetRequest(requestUri), ct);
+        }
+        catch (Exception e)
+        {
+            return Result.Fail(new ExceptionalError(e))
+                .WithReason(new UrlReason(requestUri));
+        }
 
         try
         {
@@ -145,7 +155,17 @@ public async Task<Result<TAbstract>> Get<TAbstract, TConcrete>(string requestUri
         where TConcrete : TAbstract
     {
         HttpClient httpClient = CreateClient();
-        using HttpResponseMessage response = await httpClient.SendAsync(CreateGetRequest(requestUri), ct);
+        HttpResponseMessage response;
+
+        try
+        {
+            response = await httpClient.SendAsync(CreateGetRequest(requestUri), ct);
+        }
+        catch (Exception e)
+        {
+            return Result.Fail(new ExceptionalError(e))
+                .WithReason(new UrlReason(requestUri));
+        }
 
         try
         {