Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Completions with special characters (e.g. '"&$`) are quoted #27

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

domsleee
Copy link
Owner

@domsleee domsleee commented Sep 5, 2024

Mentioned #24 (comment)

New behaviour is to add single quotes around completions with special characters.

An example package.json file:

{
    "scripts": {
        "with space": "echo hello world",
        "withsingle'quote": "echo hello world",
        "withdouble\"quote": "echo hello world",
        "with`backtick": "echo hello world",
        "with&ampersand": "echo hello world",
        "with$dollar": "echo hello world"
    }
}
Old New
with space 'with space'
withsingle'quote 'withsingle''quote'
withsingle"quote 'withdouble"quote'
with`backtick" 'with`backtick'
with&ampersand 'with&ampersand'
with$dollar 'with$dollar'

@domsleee domsleee force-pushed the fix/quotes-and-spaces-completions branch 3 times, most recently from 7375d38 to 195a014 Compare September 6, 2024 13:12
@domsleee domsleee changed the title fix: Completions with space/quote/doublequotes are quoted fix: Completions with space/quote/doublequotes/backticks are quoted Sep 6, 2024
@domsleee domsleee changed the title fix: Completions with space/quote/doublequotes/backticks are quoted fix: Completions with special characters (e.g. '"&`) are quoted Sep 6, 2024
@domsleee domsleee force-pushed the fix/quotes-and-spaces-completions branch from 195a014 to d092c52 Compare September 6, 2024 13:22
@domsleee domsleee changed the title fix: Completions with special characters (e.g. '"&`) are quoted fix: Completions with special characters (e.g. '"&$`) are quoted Sep 9, 2024
@domsleee domsleee merged commit 43dcb25 into main Sep 9, 2024
11 checks passed
@domsleee domsleee deleted the fix/quotes-and-spaces-completions branch September 9, 2024 12:02
@domsleee domsleee mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant