-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows switching of Quai and Qi coinbases based on MinerPreference flag #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djadih
requested review from
wizeguyy,
kiltsonfire and
gameofpointers
as code owners
October 10, 2024 19:52
Djadih
force-pushed
the
miner-preference
branch
from
October 10, 2024 19:53
213632d
to
ad116da
Compare
Refactoring so that it doesn't swap. Instead, primary and secondary will need to be renamed in the config file and we will just indicate preference via the flag. |
wizeguyy
previously approved these changes
Oct 11, 2024
wizeguyy
reviewed
Oct 11, 2024
wizeguyy
reviewed
Oct 11, 2024
Djadih
force-pushed
the
miner-preference
branch
from
October 11, 2024 16:45
ad116da
to
026c54b
Compare
Djadih
force-pushed
the
miner-preference
branch
2 times, most recently
from
October 11, 2024 20:43
5b13506
to
88e6da0
Compare
Djadih
force-pushed
the
miner-preference
branch
from
October 11, 2024 20:50
88e6da0
to
33991f4
Compare
Djadih
force-pushed
the
miner-preference
branch
from
October 14, 2024 17:00
f5df508
to
57ee80b
Compare
Testing:
|
Djadih
force-pushed
the
miner-preference
branch
5 times, most recently
from
October 15, 2024 15:30
4edab00
to
f963298
Compare
wizeguyy
approved these changes
Oct 15, 2024
Djadih
force-pushed
the
miner-preference
branch
from
October 15, 2024 19:23
f963298
to
0efe089
Compare
gameofpointers
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.