Sync fixes and append queue updates #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gameofpointers
requested review from
wizeguyy and
kiltsonfire
as code owners
gameofpointers
force-pushed
the
downloader-fix
branch
2 times, most recently
from
9b2844c
to
9e06aee
Compare
jdowning100
reviewed
Sep 6, 2023
jdowning100
reviewed
Sep 6, 2023
jdowning100
reviewed
Sep 6, 2023
jdowning100
reviewed
Sep 6, 2023
gameofpointers
force-pushed
the
downloader-fix
branch
2 times, most recently
from
fc99f5c
to
42641cd
Compare
jdowning100
previously approved these changes
Sep 6, 2023
…b done in Region/Prime Region and Prime subscribes to the chain head feed and never consumes it in the worker, it is solely meant to be consumed by the asyncPendingHeaderLoop
gameofpointers
force-pushed
the
downloader-fix
branch
from
42641cd
to
0c785a6
Compare
jdowning100
previously approved these changes
Sep 6, 2023
kiltsonfire
requested changes
Sep 6, 2023
* Different retry threshold for the Prime, Region and Zone * If the parent of the block is already in the chain, just appending the block * Only adding to the hash priority list at the tip, this is done to save unbounded ram usage
* Downloader Queue was not working if we had two consecutive dom blocks * doneCh in the sync was blocking the future downloads, this is fixed by increasing the channel size * Changed the min peers from 1 to 3 for the sync * Updated the forceSyncCycle to 60 seconds from 10 secs
…ending etx from random peer
gameofpointers
force-pushed
the
downloader-fix
branch
from
0c785a6
to
2fc3b3a
Compare
jdowning100
approved these changes
Sep 6, 2023
kiltsonfire
approved these changes
Sep 6, 2023
gameofpointers
temporarily deployed
to
quai-sandbox
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dominant-strategies/core-dev
Commit explanations are in the git commit messages