All slices run headerchain and processing state only on specified SLICES from network.env #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gameofpointers
force-pushed
the
processing-state
branch
12 times, most recently
from
b4e4657
to
bd8cff0
Compare
gameofpointers
force-pushed
the
processing-state
branch
from
bd8cff0
to
d8efc08
Compare
jdowning100
reviewed
Aug 23, 2023
jdowning100
reviewed
Aug 23, 2023
jdowning100
reviewed
Aug 23, 2023
wizeguyy
reviewed
Aug 23, 2023
wizeguyy
reviewed
Aug 23, 2023
wizeguyy
reviewed
Aug 23, 2023
wizeguyy
reviewed
Aug 23, 2023
wizeguyy
reviewed
Aug 23, 2023
jdowning100
reviewed
Aug 23, 2023
jdowning100
previously approved these changes
Aug 23, 2023
There was a problem hiding this comment.
I would like the codepath for nodes that don't have state (region, prime, and zones that don't process state) to be the same for readability and bug fixing purposes. Otherwise, looks good to me.
Edit: #1053
…doesn't process same block twice
gameofpointers
force-pushed
the
processing-state
branch
from
d8efc08
to
260abdc
Compare
gameofpointers
force-pushed
the
processing-state
branch
from
260abdc
to
7bc167a
Compare
… for the slices that are specified on the startup. Consensus is achieved only using the POEM check. In case of discordence in the doms, signal is passed from the zone to resolve the Dom decision.
…on doesn't get the broadcast Added another data path if dom doesnt receive a broadcast, sub will inform them
gameofpointers
force-pushed
the
processing-state
branch
from
7bc167a
to
1faf905
Compare
jdowning100
approved these changes
Aug 23, 2023
wizeguyy
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dominant-strategies/core-dev
Using the network.env
SLICESvariable, we can decide which slices the given node should run and Disabled all the txpool processing, state processing, worker execution, API guarding, peer rpc guarding on transaction apis, diabling the tx fetcher