GasPrice and MinerTip should only be called in Zone and fixed ethclient

dominant-strategies · Oct 18, 2024 · 5471a05 · 5471a05
1 parent 8187d11
commit 5471a05
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/internal/quaiapi/quai_api.go b/internal/quaiapi/quai_api.go
@@ -56,11 +56,17 @@ func NewPublicQuaiAPI(b Backend) *PublicQuaiAPI {
 
 // GasPrice returns a suggestion for a gas price for legacy transactions.
 func (s *PublicQuaiAPI) GasPrice(ctx context.Context) (*hexutil.Big, error) {
+	if s.b.NodeLocation().Context() != common.ZONE_CTX {
+		return (*hexutil.Big)(big.NewInt(0)), errors.New("gasPrice call can only be made in zone chain")
+	}
 	return (*hexutil.Big)(s.b.GetMinGasPrice()), nil
 }
 
 // MinerTip returns the gas price of the pool
 func (s *PublicQuaiAPI) MinerTip(ctx context.Context) *hexutil.Big {
+	if s.b.NodeLocation().Context() != common.ZONE_CTX {
+		return (*hexutil.Big)(big.NewInt(0))
+	}
 	return (*hexutil.Big)(s.b.GetPoolGasPrice())
 }
 

diff --git a/quaiclient/ethclient/ethclient.go b/quaiclient/ethclient/ethclient.go
@@ -338,8 +338,8 @@ func (ec *Client) ContractSizeAt(ctx context.Context, account common.MixedcaseAd
 	return (*big.Int)(&result), err
 }
 
-func (ec *Client) GetOutpointsByAddress(ctx context.Context, address common.MixedcaseAddress) (map[string]*types.OutpointAndDenomination, error) {
-	var outpoints map[string]*types.OutpointAndDenomination
+func (ec *Client) GetOutpointsByAddress(ctx context.Context, address common.MixedcaseAddress) ([]*types.OutpointAndDenomination, error) {
+	var outpoints []*types.OutpointAndDenomination
 	err := ec.c.CallContext(ctx, &outpoints, "quai_getOutpointsByAddress", address.Original())
 	return outpoints, err
 }