Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add component definitions for the following four classes returned by
Config
:DuplicateColumnHandler
ScriptFileLoader
SqlBuilderSettings
StatisticManager
Default Components
DuplicateColumnHandler
ConfigSupport.defaultDuplicateColumnHandler
as the default component.ScriptFileLoader
ResourceLoader
and set it as the default component.SqlBuilderSettings
shouldRemoveBlockComment
methodPredicate<String>
defined as a component namedshouldRemoveBlockComment
, if available.false
.shouldRemoveLineComment
methodPredicate<String>
defined as a component namedshouldRemoveLineComment
, if available.false
.shouldRemoveBlankLines
methoddoma.sql-builder-settings.should-remove-blank-lines
property.shouldRequireInListPadding
methoddoma.sql-builder-settings.should-require-in-list-padding
property.StatisticManager
DefaultStatisticManager
as the default component. Pass the value of thedoma.statistic-manager.enabled
property to the constructor.These can be overridden by the user by defining components.
Properties
doma.sql-builder-settings.should-remove-blank-lines
:boolean
SqlBuilderSettings.shouldRemoveBlankLines()
.doma.sql-builder-settings.should-require-in-list-padding
:boolean
SqlBuilderSettings.shouldRequireInListPadding()
.doma.throw-exception-if-duplicate-column
:boolean
true
,ThrowingDuplicateColumnHandler
is used as the implementation class ofDuplicateColumnHandler
.doma.statistic-manager.enabled
:bool
true
, constructs aDefaultStatisticManager
withenabled
set totrue
.Future Plans
We will integrate with Micrometer to send the statistical data collected by
StatisticManager
.Since this requires the committers to have an in-depth understanding of Micrometer and
StatisticManager
, it may take some time to implement.