Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org.seasar.doma:doma to v2.57.0 #212

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 20, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.seasar.doma:doma-processor 2.56.0 -> 2.57.0 age adoption passing confidence
org.seasar.doma:doma-core 2.56.0 -> 2.57.0 age adoption passing confidence
org.seasar.doma:doma-slf4j 2.56.0 -> 2.57.0 age adoption passing confidence

Release Notes

domaframework/doma (org.seasar.doma:doma-processor)

v2.57.0

Compare Source

What's Changed
📢 Announcement
New Features
Bug Fixes
Dependency Upgrades

Full Changelog: domaframework/doma@2.56.0...2.57.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from nakamura-to March 20, 2024 15:20
@renovate renovate bot force-pushed the renovate/org.seasar.doma-doma branch 2 times, most recently from 6d49bbb to 30bb353 Compare March 26, 2024 21:16
@backpaper0
Copy link
Member

java.lang.ClassNotFoundException: org.seasar.doma.jdbc.query.DuplicateKeyType が発生している

org.seasar.doma.jdbc.query.DuplicateKeyTypedomaframework/doma#1064 で追加された列挙型。
そのためpom.xmlに書かれたバージョンのDomaでコンパイルし、Doma 2.49.0で実行するtest-slf4j-backward-compatibleジョブが失敗している。

test-slf4j-backward-compatibleジョブを追加した理由を確認し、今現在でもこのジョブが必要なのか整理した上で対応を決める。

@backpaper0
Copy link
Member

test-slf4j-backward-compatibleジョブは #116 で追加している。
同じプルリクエストでorg.seasar.doma.jdbc.Slf4jJdbcLoggerorg.seasar.doma.slf4j.Slf4jJdbcLoggerにリネームされたことに起因するフォールバック処理を追加しており、それをテストするためのジョブ(横道へ逸れるが「Minimal support for module system」というプルリクエストで行う内容ではない。プルリクエストを分けるべきだった)。

今後の修正で壊れる可能性が低い箇所なため、test-slf4j-backward-compatibleジョブを削除することとする。

@renovate renovate bot force-pushed the renovate/org.seasar.doma-doma branch from 30bb353 to 4f84e30 Compare March 27, 2024 12:10
@renovate renovate bot force-pushed the renovate/org.seasar.doma-doma branch from 4f84e30 to eb8faa7 Compare March 27, 2024 12:11
@backpaper0 backpaper0 merged commit bd243f1 into master Mar 27, 2024
14 checks passed
@backpaper0 backpaper0 deleted the renovate/org.seasar.doma-doma branch March 27, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant