Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In order to support multiple index types, create interface types for prolly Maps, and make the tree.MutableMap class generic. #8555

Merged
merged 7 commits into from
Nov 14, 2024
Merged

In order to support multiple index types, create interface types for prolly Maps, and make the tree.MutableMap class generic. #8555

merged 7 commits into from
Nov 14, 2024

Conversation

nicktobey
Copy link
Contributor

No description provided.

@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8529de5 ok 5937457
version total_tests
8529de5 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
6b2e8a0 ok 5937457
version total_tests
6b2e8a0 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
bbebb1f ok 5937457
version total_tests
bbebb1f 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
20280fd ok 5937457
version total_tests
20280fd 5937457
correctness_percentage
100.0

jycor
jycor approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicktobey nicktobey merged commit aa936c1 into main Nov 14, 2024
21 checks passed
@nicktobey nicktobey deleted the nicktobey/generic-map branch November 14, 2024 00:34
@BrewTestBot BrewTestBot mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicktobey @coffeegoddd @jycor