You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors the go/performance/utils/sysbench_runner tool to reduce the duplicated code and fix the profiling support.
It renames go/performance/utils/sysbench_runner to go/performance/utils/benchmark_runner and removed go/performance/utils/tpcc_runner.
It also removes the configuration file support, as that was only used for CI testing. Now we test with go tests in go/performance/utils/benchmark_runner/run_tests.go during CI (PR for that to come).
Run is the used to run sysbench tests, RunTpcc is used to run tpcc tests.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
go/performance/utils/sysbench_runnertool to reduce the duplicated code and fix the profiling support.It renames
go/performance/utils/sysbench_runnertogo/performance/utils/benchmark_runnerand removedgo/performance/utils/tpcc_runner.It also removes the configuration file support, as that was only used for CI testing. Now we test with go tests in
go/performance/utils/benchmark_runner/run_tests.goduring CI (PR for that to come).Runis the used to run sysbench tests,RunTpccis used to run tpcc tests.