Bug fix: IndexedDoltTable
didn't fully implement DoltTable
's interface
#7490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexedDoltTable
wasn't fully compatible withDoltTable
's interface, which was causing some queries to execute incorrectly due to using the wrong field indexes. This only happened with queries where the table was used in a read-only context (such as anAS OF
query), since in a read-write contextWritableIndexedDoltTable
is used, which is composed of aWritableDoltTable
, so fully inherits the interface.IndexedDoltTable
is now consistent with that, and is now composed of aDoltTable
instance. This enables the GMS code inassignExecIndexes
to use the correct, limited schema of the secondary index and to apply the correct field indexes.Fixes: #7488