Refactor HexColorDisplay to functional component #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into Refactor-to-functional-component
|
@Tamir198 Actually I'm running your PR with storybook and it seems like it's not marking the items anymore. |
|
I will check and compare my code to the old one and fix it. |
|
@Tamir198 OK I understand the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After I changed the code I saw those linter issues (all inside HexColorDisplay component):
I think that for now, we can ignore this:
That's because all those functions need to go out to separate files (Extract out all logic into util so it can be tested) and it seems like they will be defined on the import line anyway.
Tell me what you think about that.