Merge pull request #69 from doki-theme/usabilityIssues

Usability Issue Fixes
doki-theme · May 8, 2021 · 2f0fa49 · 2f0fa49
2 parents 3466f8d + a298b2d
commit 2f0fa49
Show file tree

Hide file tree

Showing 39 changed files with 160 additions and 72 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,7 +1,11 @@
 # Change Log
 
-# 12.0.0 [Nino, Nakano Miku, Gray, & Tohru]
+# 12.1.0 [Usability Updates]
+
+- Fixed selection usability issues for all themes [#68](https://github.com/doki-theme/doki-theme-vscode/issues/68)
+- Changed the quick input panel to be opaque again. If you want it to be transparent, feel free to customize the [quick picker colors](https://code.visualstudio.com/api/references/theme-color#quick-picker-colors). I left the blurred effect on when you've installed the wallpaper.
 
+# 12.0.0 [Nino, Nakano Miku, Gray, & Tohru]
 ## 5 New Themes
 
 From the Quintessential Quintuplets series:

diff --git a/README.md b/README.md
@@ -76,17 +76,6 @@ This feature will set the background image to the current theme's official wallp
 ![Zero Two Code](./readmeStuff/wallpaper_code.png)
 ![Zero Two Code](./readmeStuff/wallpaper_background.png)
 
-**Quick Input Usability**
-
-Inorder to create a more immersive weeb experience, some panels have become see-through.
-This causes some usability issues, however installing your theme's wallpaper fixes that problem.
-
-| Before | After |
-| --- | --- | 
-| ![not usable](./readmeStuff/unusable_quickinput.png) | ![usable](./readmeStuff/useable_quickinput.png)
-
-> Note: colors can be adjusted using the [Quick picker colors](https://code.visualstudio.com/api/references/theme-color#quick-picker-colors)
-
 ## Stickers
 
 **Show sticker** allows you to control the presence of the cute sticker in the bottom right-hand corner of your IDE.

diff --git a/buildSrc/assets/templates/base.laf.template.json b/buildSrc/assets/templates/base.laf.template.json
@@ -11,12 +11,12 @@
     "peekViewResult.background": "&secondaryBackground&",
     "list.focusBackground": "&selectionBackground&",
     "quickInput.list.focusBackground": "&selectionBackground&AA",
-    "quickInput.background": "&headerColor&80",
-    "quickInput.foreground": "&infoForeground&",
+    "quickInput.foreground": "&foregroundColor&",
     "selection.background": "&accentColor&",
     "list.activeSelectionBackground": "&selectionBackground&",
     "peekViewResult.selectionBackground": "&selectionBackground&",
     "list.hoverBackground": "&selectionBackground&2A",
+    "editor.selectionHighlightBackground": "&identifierHighlight&",
     "editor.selectionBackground": "&selectionBackground&",
     "minimap.selectionHighlight": "&selectionBackground&",
     "list.activeSelectionForeground": "&selectionForeground&",
@@ -56,7 +56,7 @@
     "titleBar.border": "&borderColor&",
     "notificationCenter.border": "&borderColor&",
     "notifications.border": "&borderColor&",
-    "editorCursor.background": "&textEditorBackground&",
+    "editorCursor.background": "&accentContrastColor&",
     "terminalCursor.background": "&textEditorBackground&",
     "editorSuggestWidget.border": "&textEditorBackground&",
     "panel.background": "&textEditorBackground&",

diff --git a/buildSrc/assets/templates/dark.dim.laf.template.json b/buildSrc/assets/templates/dark.dim.laf.template.json
@@ -0,0 +1,7 @@
+{
+  "name":"dark-dim",
+  "extends":"dark",
+  "ui": {
+    "editor.selectionBackground": "&selectionBackground&66"
+  }
+}
diff --git a/buildSrc/assets/themes/bunnySenpai/mai/dark/mai.dark.vsCode.definition.json b/buildSrc/assets/themes/bunnySenpai/mai/dark/mai.dark.vsCode.definition.json
@@ -3,7 +3,9 @@
   "overrides": {},
   "laf": {
     "extends": "dark-contrast",
-    "ui": {}
+    "ui": {
+      "editor.selectionBackground": "&selectionBackground&99"
+    }
   },
   "syntax": {},
   "colors": {},

diff --git a/buildSrc/assets/themes/danganronpa/ibuki/light/ibuki.light.vsCode.definition.json b/buildSrc/assets/themes/danganronpa/ibuki/light/ibuki.light.vsCode.definition.json
@@ -1,7 +1,12 @@
 {
   "id": "697e8564-0975-4907-a34c-51f65177ebf3",
   "overrides": {},
-  "laf": {},
+  "laf": {
+    "extends": "light",
+    "ui": {
+      "editor.selectionBackground": "&selectionBackground&55"
+    }
+  },
   "syntax": {},
   "colors": {},
   "backgrounds": {

diff --git a/buildSrc/assets/themes/dragonMaid/tohru/light/tohru.light.vsCode.definition.json b/buildSrc/assets/themes/dragonMaid/tohru/light/tohru.light.vsCode.definition.json
@@ -1,7 +1,12 @@
 {
   "id": "2d049451-6e89-4325-af38-6ce889991e5b",
   "overrides": {},
-  "laf": {},
+  "laf": {
+    "extends": "light",
+    "ui": {
+      "editor.selectionBackground": "&selectionBackground&55"
+    }
+  },
   "syntax": {},
   "backgrounds": {
     "default": {

diff --git a/buildSrc/assets/themes/eva/misato/dark/misato.dark.vsCode.definition.json b/buildSrc/assets/themes/eva/misato/dark/misato.dark.vsCode.definition.json
@@ -4,12 +4,12 @@
   "laf": {
     "extends": "dark",
     "ui": {
-      "quickInput.foreground": "&keywordColor&"
+      "editor.selectionBackground": "&selectionBackground&88"
     }
   },
   "syntax": {},
   "colors": {
     "selectionBackground": "#5a293f",
     "selectionInactive": "#4b283c"
   }
-}
+}
diff --git a/buildSrc/assets/themes/eva/rei/dark/rei.dark.vsCode.definition.json b/buildSrc/assets/themes/eva/rei/dark/rei.dark.vsCode.definition.json
@@ -1,7 +1,12 @@
 {
   "id": "c262185d-9682-413b-9143-85a2dda76b2f",
   "overrides": {},
-  "laf": {},
+  "laf": {
+    "extends": "dark",
+    "ui": {
+      "editor.selectionBackground": "&selectionBackground&88"
+    }
+  },
   "syntax": {},
   "colors": {},
   "backgrounds": {

diff --git a/buildSrc/assets/themes/fate/ishtar/dark/ishtar.dark.vsCode.definition.json b/buildSrc/assets/themes/fate/ishtar/dark/ishtar.dark.vsCode.definition.json
@@ -3,7 +3,9 @@
   "overrides": {},
   "laf": {
     "extends": "dark-contrast",
-    "ui": {}
+    "ui": {
+      "editor.selectionBackground": "&selectionBackground&88"
+    }
   },
   "syntax": {},
   "colors": {

diff --git a/buildSrc/assets/themes/franxx/zeroTwo/dark/zero.two.dark.vsCode.definition.json b/buildSrc/assets/themes/franxx/zeroTwo/dark/zero.two.dark.vsCode.definition.json
@@ -3,7 +3,9 @@
   "overrides": {},
   "laf": {
     "extends": "dark-contrast",
-    "ui": {}
+    "ui": {
+      "editor.selectionBackground": "&selectionBackground&66"
+    }
   },
   "syntax": {},
   "colors": {}

diff --git a/buildSrc/assets/themes/franxx/zeroTwo/light/zero.two.light.vsCode.definition.json b/buildSrc/assets/themes/franxx/zeroTwo/light/zero.two.light.vsCode.definition.json
@@ -1,7 +1,12 @@
 {
   "id": "4fd5cb34-d36e-4a3c-8639-052b19b26ba1",
   "overrides": {},
-  "laf": {},
+  "laf": {
+    "extends": "light",
+    "ui": {
+      "editor.selectionBackground": "&selectionBackground&55"
+    }
+  },
   "syntax": {},
   "colors": {}
 }
diff --git a/buildSrc/assets/themes/highSchoolDxD/rias/dark/rias.dark.vsCode.definition.json b/buildSrc/assets/themes/highSchoolDxD/rias/dark/rias.dark.vsCode.definition.json
@@ -1,7 +1,12 @@
 {
   "id": "c5e92ad9-2fa0-491e-b92a-48ab92d13597",
   "overrides": {},
-  "laf": {},
+  "laf": {
+    "extends": "dark",
+    "ui": {
+      "editor.selectionBackground": "&selectionBackground&45"
+    }
+  },
   "syntax": {},
   "colors": {}
 }
diff --git a/buildSrc/assets/themes/highSchoolDxD/rias/onyx/rias.onyx.vsCode.definition.json b/buildSrc/assets/themes/highSchoolDxD/rias/onyx/rias.onyx.vsCode.definition.json
@@ -4,9 +4,8 @@
   "laf": {
     "extends": "dark",
     "ui": {
-      "quickInput.foreground": "&keywordColor&"
     }
   },
   "syntax": {},
   "colors": {}
-}
+}
diff --git a/buildSrc/assets/themes/killLaKill/ryuko/ryuko.vsCode.definition.json b/buildSrc/assets/themes/killLaKill/ryuko/ryuko.vsCode.definition.json
@@ -4,6 +4,7 @@
   "laf": {
     "extends": "dark",
     "ui": {
+      "editor.selectionBackground": "&selectionBackground&88",
       "quickInput.foreground": "&foregroundColor&"
     }
   },

diff --git a/buildSrc/assets/themes/killLaKill/satsuki/satsuki.vsCode.definition.json b/buildSrc/assets/themes/killLaKill/satsuki/satsuki.vsCode.definition.json
@@ -1,7 +1,12 @@
 {
   "id": "3a78b13e-dbf2-410f-bb20-12b57bff7735",
   "overrides": {},
-  "laf": {},
+  "laf": {
+    "extends": "light",
+    "ui": {
+      "editor.selectionBackground": "&selectionBackground&44"
+    }
+  },
   "syntax": {},
   "colors": {
     "selectionBackground": "#b7bcda"

diff --git a/buildSrc/assets/themes/konoSuba/aqua/dark/aqua.dark.vsCode.definition.json b/buildSrc/assets/themes/konoSuba/aqua/dark/aqua.dark.vsCode.definition.json
@@ -1,7 +1,12 @@
 {
   "id": "15e51483-1ccd-46b7-90cf-885cccaaaf2c",
   "overrides": {},
-  "laf": {},
+  "laf": {
+    "extends": "dark",
+    "ui": {
+      "editor.selectionBackground": "&selectionBackground&66"
+    }
+  },
   "syntax": {},
   "colors": {
     "constantsColor": "&secondaryAccentColor&"

diff --git a/buildSrc/assets/themes/konoSuba/darkness/dark/darkness.dark.vsCode.definition.json b/buildSrc/assets/themes/konoSuba/darkness/dark/darkness.dark.vsCode.definition.json
@@ -4,6 +4,7 @@
   "laf": {
     "extends": "dark-contrast",
     "ui": {
+      "editor.selectionBackground": "&selectionBackground&88",
       "quickInput.foreground": "&foregroundColor&"
     }
   },

diff --git a/buildSrc/assets/themes/konoSuba/megumin.vsCode.definition.json b/buildSrc/assets/themes/konoSuba/megumin.vsCode.definition.json
@@ -4,6 +4,7 @@
   "laf": {
     "extends": "dark",
     "ui": {
+      "editor.selectionBackground": "&selectionBackground&88",
       "quickInput.foreground": "&foregroundColor&"
     }
   },

diff --git a/buildSrc/assets/themes/literature/monika/dark/monika.dark.vsCode.definition.json b/buildSrc/assets/themes/literature/monika/dark/monika.dark.vsCode.definition.json
@@ -4,9 +4,9 @@
   "laf": {
     "extends": "dark",
     "ui": {
-      "quickInput.foreground": "&classNameColor&"
+      "editor.selectionBackground": "&selectionBackground&88"
     }
   },
   "syntax": {},
   "colors": {}
-}
+}
diff --git a/buildSrc/assets/themes/literature/monika/light/monika.light.vsCode.definition.json b/buildSrc/assets/themes/literature/monika/light/monika.light.vsCode.definition.json
@@ -1,7 +1,12 @@
 {
   "id": "9a310731-ab2d-40f5-b502-fa5419f799a2",
   "overrides": {},
-  "laf": {},
+  "laf": {
+    "extends": "light",
+    "ui": {
+      "editor.selectionBackground": "&selectionBackground&33"
+    }
+  },
   "syntax": {},
   "colors": {}
 }
diff --git a/buildSrc/assets/themes/literature/natsuki/dark/natsuki.dark.vsCode.definition.json b/buildSrc/assets/themes/literature/natsuki/dark/natsuki.dark.vsCode.definition.json
@@ -4,7 +4,7 @@
   "laf": {
     "extends": "dark",
     "ui": {
-      "quickInput.foreground": "&classNameColor&"
+      "editor.selectionBackground": "&selectionBackground&66"
     }
   },
   "syntax": {},
@@ -14,4 +14,4 @@
       "anchor": "right"
     }
   }
-}
+}
diff --git a/buildSrc/assets/themes/literature/natsuki/light/natsuki.light.vsCode.definition.json b/buildSrc/assets/themes/literature/natsuki/light/natsuki.light.vsCode.definition.json
@@ -6,7 +6,8 @@
     "ui": {
       "editor.lineHighlightBackground": "&headerColor&77",
       "sideBarSectionHeader.background": "&headerColor&",
-      "activityBar.background": "&headerColor&"
+      "activityBar.background": "&headerColor&",
+      "editor.selectionBackground": "&selectionBackground&33"
     }
   },
   "syntax": {},

diff --git a/buildSrc/assets/themes/literature/sayori/dark/sayori.dark.vsCode.definition.json b/buildSrc/assets/themes/literature/sayori/dark/sayori.dark.vsCode.definition.json
@@ -1,7 +1,12 @@
 {
   "id": "b0340303-0a5a-4a20-9b9c-fc8ce9880078",
   "overrides": {},
-  "laf": {},
+  "laf": {
+    "extends": "dark",
+    "ui": {
+      "editor.selectionBackground": "&selectionBackground&88"
+    }
+  },
   "syntax": {},
   "colors": {}
 }
diff --git a/buildSrc/assets/themes/literature/sayori/light/sayori.light.vsCode.definition.json b/buildSrc/assets/themes/literature/sayori/light/sayori.light.vsCode.definition.json
@@ -1,7 +1,12 @@
 {
   "id": "cb8ef4b7-0844-4a04-b08b-754086598de4",
   "overrides": {},
-  "laf": {},
+  "laf": {
+    "extends": "light",
+    "ui": {
+      "editor.selectionBackground": "&selectionBackground&33"
+    }
+  },
   "syntax": {},
   "colors": {}
 }
diff --git a/buildSrc/assets/themes/literature/yuri/dark/yuri.dark.vsCode.definition.json b/buildSrc/assets/themes/literature/yuri/dark/yuri.dark.vsCode.definition.json
@@ -4,7 +4,6 @@
   "laf": {
     "extends": "dark",
     "ui": {
-      "quickInput.foreground": "&classNameColor&"
     }
   },
   "syntax": {},

diff --git a/buildSrc/assets/themes/literature/yuri/light/yuri.light.vsCode.definition.json b/buildSrc/assets/themes/literature/yuri/light/yuri.light.vsCode.definition.json
@@ -1,7 +1,12 @@
 {
   "id": "cecf3f92-76d4-4f14-9a9c-3d558b6b3b68",
   "overrides": {},
-  "laf": {},
+  "laf": {
+    "extends": "light",
+    "ui": {
+      "editor.selectionBackground": "&selectionBackground&33"
+    }
+  },
   "syntax": {},
   "colors": {}
 }
diff --git a/buildSrc/assets/themes/miscellaneous/miku/miku.vsCode.definition.json b/buildSrc/assets/themes/miscellaneous/miku/miku.vsCode.definition.json
@@ -1,7 +1,12 @@
 {
   "id": "bc12b380-1f2a-4a9d-89d8-388a07f1e15f",
   "overrides": {},
-  "laf": {},
+  "laf": {
+    "extends": "dark",
+    "ui": {
+      "editor.selectionBackground": "&selectionBackground&66"
+    }
+  },
   "syntax": {},
   "backgrounds": {
     "secondary": {

diff --git a/buildSrc/assets/themes/monsterGirls/miia/dark/miia.dark.vsCode.definition.json b/buildSrc/assets/themes/monsterGirls/miia/dark/miia.dark.vsCode.definition.json
@@ -4,6 +4,7 @@
   "laf": {
     "extends": "dark-contrast",
     "ui": {
+      "editor.selectionBackground": "&selectionBackground&88"
     }
   },
   "backgrounds": {

diff --git a/buildSrc/assets/themes/oreGairu/yukino/dark/yukino.dark.vsCode.definition.json b/buildSrc/assets/themes/oreGairu/yukino/dark/yukino.dark.vsCode.definition.json
@@ -4,6 +4,7 @@
   "laf": {
     "extends": "dark",
     "ui": {
+      "editor.selectionBackground": "&selectionBackground&AA",
       "quickInput.foreground": "&foregroundColor&"
     }
   },

diff --git a/buildSrc/assets/themes/quintuplets/miku/dark/miku.dark.vsCode.definition.json b/buildSrc/assets/themes/quintuplets/miku/dark/miku.dark.vsCode.definition.json
@@ -2,7 +2,7 @@
   "id": "d96c6599-ebf8-4359-ae26-19f79b69e919",
   "overrides": {},
   "laf": {
-    "extends": "dark-contrast",
+    "extends": "dark-contrast,dark-dim",
     "ui": {
     }
   },