Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor-opt(torii-grpc): subscriptions no db fetch #2455

Merged
merged 4 commits into from
Sep 20, 2024

cmt

d67dc75
Select commit
Loading
Failed to load commit list.
Merged

refactor-opt(torii-grpc): subscriptions no db fetch #2455

cmt
d67dc75
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 19, 2024 in 7s

68.36% (+0.07%) compared to 82a23a5

View this Pull Request on Codecov

68.36% (+0.07%) compared to 82a23a5

Details

Codecov Report

Attention: Patch coverage is 42.30769% with 15 lines in your changes missing coverage. Please review.

Project coverage is 68.36%. Comparing base (82a23a5) to head (d67dc75).

Files with missing lines Patch % Lines
...ates/torii/grpc/src/server/subscriptions/entity.rs 20.00% 8 Missing ⚠️
...rii/grpc/src/server/subscriptions/event_message.rs 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2455      +/-   ##
==========================================
+ Coverage   68.29%   68.36%   +0.07%     
==========================================
  Files         365      365              
  Lines       48034    47951      -83     
==========================================
- Hits        32805    32782      -23     
+ Misses      15229    15169      -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.