Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(workflows) add GitHub Actions workflow for preview builds #2446
ci(workflows) add GitHub Actions workflow for preview builds #2446
Changes from all commits
6c6b40d
26ad014
662d194
0fa007b
6605027
c130548
ce3441c
5a4bec7
27e445c
2d4a062
e9076a6
0dcec2c
a18222b
259fb63
ea45f9d
053a4b5
c781b15
4afe768
48c8e0a
d9c53d1
44e5efc
64d19a1
c91600f
3198ed2
87d2b3e
ec35a9d
3f8d57b
cb80ecc
cf7cc62
55819aa
ba0273b
a09b21b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sensei, there are a few things that can be improved in the
builder
stage.The pre-caching step on line 30 is redundant since the same command is already executed on line 36. Consider removing the redundant command to simplify the Dockerfile and reduce build time.
Also, copying the application code again on line 33 is unnecessary since it was already copied in the
planner
stage. Setting thePATH
environment variable on line 34 is also unnecessary since it is not used in the final image.Here's how you can refactor it:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this still caches building the deps, so it certainly speeds up the build when dependencies don't change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steebchen Ohayo, sensei! Thank you for the clarification. I understand now that the pre-caching step helps speed up the build when dependencies don't change. I'll keep this in mind for future reviews.
(・ェ・)
Learnings added