Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(torii): delete entity in all tables & array references for entity delete! #2072

Merged
merged 10 commits into from
Jun 19, 2024

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Jun 17, 2024

@Larkooo Larkooo changed the title refactor(torii): delete all tables for entity for delete refactor(torii): delete all tables for entity delete! Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 93.20988% with 11 lines in your changes missing coverage. Please review.

Project coverage is 68.89%. Comparing base (aa92675) to head (413ad54).

Files Patch % Lines
crates/torii/core/src/sql.rs 71.05% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2072      +/-   ##
==========================================
+ Coverage   68.40%   68.89%   +0.49%     
==========================================
  Files         326      326              
  Lines       40642    40793     +151     
==========================================
+ Hits        27801    28106     +305     
+ Misses      12841    12687     -154     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Larkooo Larkooo marked this pull request as ready for review June 18, 2024 07:36
@Larkooo Larkooo changed the title refactor(torii): delete all tables for entity delete! refactor(torii): delete all tables & array references for entity delete! Jun 18, 2024
@Larkooo Larkooo requested a review from glihm June 18, 2024 08:02
@Larkooo Larkooo changed the title refactor(torii): delete all tables & array references for entity delete! refactor(torii): delete entity in all tables & array references for entity delete! Jun 18, 2024
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a reset_player_config which has some interesting types for testing.

Torii is crashing with:

thread 'main' panicked at crates/torii/core/src/sql.rs:538:79:
called `Result::unwrap()` on an `Err` value: MissingFieldElement
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Path to repro:

sozo build
sozo migrate apply
sozo execute dojo_examples::actions::actions spawn
sozo execute dojo_examples::actions::actions set_player_config -c str:glihm
sozo execute dojo_examples::actions::actions reset_player_config

@glihm glihm merged commit fc44c36 into dojoengine:main Jun 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants