-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(torii): delete entity in all tables & array references for entity delete! #2072
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2072 +/- ##
==========================================
+ Coverage 68.40% 68.89% +0.49%
==========================================
Files 326 326
Lines 40642 40793 +151
==========================================
+ Hits 27801 28106 +305
+ Misses 12841 12687 -154 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a reset_player_config
which has some interesting types for testing.
Torii is crashing with:
thread 'main' panicked at crates/torii/core/src/sql.rs:538:79:
called `Result::unwrap()` on an `Err` value: MissingFieldElement
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Path to repro:
sozo build
sozo migrate apply
sozo execute dojo_examples::actions::actions spawn
sozo execute dojo_examples::actions::actions set_player_config -c str:glihm
sozo execute dojo_examples::actions::actions reset_player_config
#2071