Storage layout #1772
Closed
Storage layout #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remybar
force-pushed
the
storage-layout
branch
3 times, most recently
from
453bcb4
to
3f667ea
Compare
remybar
force-pushed
the
storage-layout
branch
3 times, most recently
from
dfe5458
to
ce8ad9f
Compare
glihm
reviewed
Apr 15, 2024
tarrencev
reviewed
Apr 21, 2024
| @@ -1,7 +1,8 @@ | |||
| use starknet::{ContractAddress, get_caller_address}; | |||
|
|
|||
| // TODO import all this when complex benchmarks are merged | |||
| #[derive(Model, Copy, Drop, Serde)] | |||
| #[derive(Introspect, Copy, Drop, Serde)] | |||
| #[dojo::model] | |||
There was a problem hiding this comment.
In my original PR I removed auto deriving Introspect for models but I think we should probably add it back. Since there I don't think there is a case where we want model without introspect. Not necessary to land in this PR though
remybar
force-pushed
the
storage-layout
branch
2 times, most recently
from
8f40214
to
d6e829e
Compare
remybar
force-pushed
the
storage-layout
branch
7 times, most recently
from
62e2c25
to
822e3b4
Compare
|
As the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1669.
[Work in progress]
from
namehashbranch rebased tomainto have thedojo::modelattribute.