Bump dojo starter to V1.0.0 rc.1 #90
Conversation
gianalarcon
commented
Nov 4, 2024
gianalarcon
commented
- Bump dojo starter to V1.0.0 rc.1
- Add minor changes
scripts/move.sh
Outdated
There was a problem hiding this comment.
Could we remove the world address extraction from the manifest? sozo execute is able to actually recompute it from the world and the config found in dojo_dev.toml. 👍
There was a problem hiding this comment.
(in all scripts, to give also users the good practice to use sozo execute)
There was a problem hiding this comment.
We could actually move those scripts to the README at some point? But may be handy to use for users by simply executing them I guess.
src/systems/actions.cairo
Outdated
| impl InternalImpl of InternalTrait { | ||
| fn world_default(self: @ContractState) -> dojo::world::WorldStorage { | ||
| self.world(@"dojo_starter") | ||
| } | ||
| } |
There was a problem hiding this comment.
Good to have put this down here, could we add a comment on why this is interesting practice to have? Since the namespace is the same in this example, it's a good way for the users to not hardcode it. 👍
|
Thanks @gianalarcon! |
