Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v7 into df4ad34 #6

Open
wants to merge 39 commits into
base: v7
Choose a base branch
from

Conversation

haroune-mohammedi
Copy link

This brings the no validation account commit from upstream blockifier

giladchase and others added 30 commits July 23, 2023 14:57
*     Update compiler version to 2.1.0-rc1. (starkware-libs#768)

* Merge remote-tracking branch 'origin/main-v0.12.1' into elin/merge-main-v0.12.1-into-main

* Merge pull request starkware-libs#769 from starkware-libs/elin/merge-main-v0.12.1-into-main

Elin/merge main v0.12.1 into main (starkware-libs#769)

Co-Authored-By: Arnon Hod <[email protected]>
Co-Authored-By: Elin Tulchinsky <[email protected]>
* Refactor run_or_revert.
Check actual fee before committing the execution result. Revert and charge max fee when running out of gas instead of failing due to FeeTransferError and charging nothing.

* PR changes
…fier/merges/merge-v0121-to-v0122

Elin/blockifier/merges/merge v0121 to v0122
also, switch `syscall_counter` to borrow in `get_additional_os_resources` to avoid needless cloning. (starkware-libs#809)
…mitting changes. else, revert. (starkware-libs#811)

* check that user has enough remaining balance to pay for tx before committing changes. else, revert.

* add test for revert on overdraft

* PR
Some changes made in `1.0.72` break our Python build, will investigate,
for now we don't anything higher than this.
…main-v0.12.1-into-main-v0.12.2

Elin/merge main v0.12.1 into main v0.12.2
…tStateDiff` (starkware-libs#911)

This ensures that the `CommitmentStateDiff` doesn't contain any write
actions that don't change the existing value.

This is a performance optimization, since it saves the state diff
consumer from doing this at a later stage, which could be costly.
…in-v0.12.2-into-main-v0.12.3 (no conflicts).
…main-v0.12.2-into-main-v0.12.3

Elin/merge main v0.12.2 into main v0.12.3
@kariy
Copy link
Member

kariy commented Nov 23, 2023

seems like you've included some commits from the origin repo that are newer than this commit f185eba (the latest commit on v7 branch before Dojo commits were added) which i believe includes more breaking changes than we need for the validate flag.

for simplicity, you can just create a branch from this commit starkware-libs@df4ad34 and just add the Dojo changes that on v7 branch to the new branch.

@kariy
Copy link
Member

kariy commented Nov 23, 2023

hey to avoid confusion, i already created the validate-flag branch for you.

you use this commit 2b4a0e5 for the Dojo PR

@haroune-mohammedi
Copy link
Author

What I did is exactly merging v7 into starkware-libs@df4ad34

git chekout df4ad34
git checkout -b merge-v7-into-df4ad34
git merge v7
# Fix merge conflicts then
git commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.