Webpack 5 #434
Draft
Webpack 5 #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettierCurrently has several deprecation warnings, library types don't work, and using hashes in chunk file names breaks the service workers. May make sense to revisit these issues closer to the full release of webpack after there are more related plugin/loader updates.
On a dev build this update didn't result in any performance improvements on a fresh dojo project. For a dist build it is actually 50% slower on the first build (from 12 seconds to 18 seconds) and on subsequent builds still takes 14 seconds with the Webpack 5 changes, 2 seconds slower than the current build
Description:
Upgrade to webpack 5
Resolves #434