Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python flake8 issues #4933

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Fix Python flake8 issues #4933

merged 2 commits into from
Jan 22, 2025

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Jan 21, 2025

The pki-lint script has been split into python-lint.py and python-flake8.py such that they can run independently. This way a failure in one test will not prevent the other test from running.

Note: The remaining pylint issue will be addressed by PR #4931.

The pki-lint script has been split into python-lint.py and
python-flake8.py such that they can run independently. This
way a failure in one test will not prevent the other test
from running.
@edewata edewata requested a review from fmarco76 January 21, 2025 23:55
Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The split is very good for the tests!

@edewata
Copy link
Contributor Author

edewata commented Jan 22, 2025

@fmarco76 Thanks!

@edewata edewata merged commit c0ceb9b into dogtagpki:master Jan 22, 2025
163 of 171 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants