ACME PKI issuer: add support for Authority ID or DN #4903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbra
force-pushed
the
acme-use-authority-id-or-dn
branch
4 times, most recently
from
dbd69d0 to
4873f7f
Compare
Allow issuing ACME certificates using a specific authority. This would allow FreeIPA to specify a particular subCA to handle ACME certificates. Fixes: dogtagpki#4902 Signed-off-by: Alexander Bokovoy <[email protected]>
abbra
force-pushed
the
acme-use-authority-id-or-dn
branch
3 times, most recently
from
c74311f to
9dff709
Compare
Signed-off-by: Alexander Bokovoy <[email protected]>
abbra
force-pushed
the
acme-use-authority-id-or-dn
branch
from
9dff709 to
90ddf9c
Compare
|
|
I added a basic test that puts main IPA CA ID as the authority ID to issue ACME certificate. This test now passes, I think the PR is ready for review. |
|
@abbra Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow issuing ACME certificates using a specific authority. This would allow FreeIPA to specify a particular subCA to handle ACME certificates.
Fixes: #4902