Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container tests to use Podman #4759

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

edewata
Copy link
Contributor

@edewata edewata commented May 29, 2024

The container tests have been updated to use Podman instead of Docker (except for ACME container test due to a compatibility issue with Certbot). The docker command is now just an alias to podman.

In Podman the containers will run as a non-root user with random UID so the tests now will only verify the group owner of the files.

Also in Podman the containers need to be connected to the network as soon as it's created using docker run command instead of using a separate docker network connect command.

The tests have also been updated to capture the files generated by the containers in the shared folders.

@edewata edewata requested a review from fmarco76 May 29, 2024 15:16
Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented May 29, 2024

@fmarco76 Thanks!

The container tests have been updated to use Podman instead of
Docker (except for ACME container test due to a compatibility
issue with Certbot). The docker command is now just an alias to
podman.

In Podman the containers will run as a non-root user with random
UID so the tests now will only verify the group owner of the
files.

Also in Podman the containers need to be connected to the network
as soon as it's created using docker run command instead of using
a separate docker network connect command.

The tests have also been updated to capture the files generated
by the containers in the shared folders.
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@edewata edewata merged commit 95c31ea into dogtagpki:master May 29, 2024
141 of 148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants