Hash enroll servlet free vlv #4756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
edewata
approved these changes
May 28, 2024
| @@ -304,15 +302,15 @@ protected void processX509(CMSRequest cmsReq) | |||
|
|
|||
| String certauthEnrollType = null; | |||
|
|
|||
| if (certAuthEnroll == true) { | |||
| if (certAuthEnroll) { | |||
| certauthEnrollType = | |||
| httpParams.getValueAsString("certauthEnrollType", null); | |||
| if (certauthEnrollType != null) { | |||
| if (certauthEnrollType.equals("dual")) { | |||
There was a problem hiding this comment.
For consistency we can use CERT_AUTH_DUAL here.
Fixed the following sonar identified problems: - removed some variable not used - merged catch exceptions - Replaced StringBuffer with StringBuilder - Modify the logs to use string format instead of concatenation
fmarco76
force-pushed
the
HashEnrollServletFreeVLV
branch
from
059a070 to
a5fa466
Compare
|
@edewata Thanks! I have updated as for your comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.