Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ACME container #4748

Merged
merged 3 commits into from
May 20, 2024
Merged

Update ACME container #4748

merged 3 commits into from
May 20, 2024

Conversation

edewata
Copy link
Contributor

@edewata edewata commented May 18, 2024

The ACME container has been updated to use the default instance (i.e. pki-tomcat) instead of tomcat@pki which will be more consistent with the CA container and will make it easier to migrate from a regular deployment.

The paths of ACME container volumes have been updated to simplify deployment and to avoid collisions with instance files/folders.

The deployment doc for ACME container has been updated to use a network instead of a pod.

https://github.com/edewata/pki/blob/acme/docs/installation/podman/Deploying_PKI_ACME_Responder_on_Podman.md
https://github.com/edewata/pki/blob/acme/docs/changes/v11.6.0/Server-Changes.adoc

edewata added 3 commits May 17, 2024 20:46
The deployment doc for ACME container has been updated to
use a network instead of a pod.
The paths of ACME container volumes have been updated to
simplify deployment and to avoid collisions with instance
files/folders.
The ACME container has been updated to use the default
instance (i.e. pki-tomcat) instead of tomcat@pki which will
be more consistent with the CA container and will make it
easier to migrate from a regular deployment.
@edewata edewata requested a review from fmarco76 May 18, 2024 02:05
Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented May 20, 2024

@fmarco76 Thanks!

@edewata edewata merged commit b5a792d into dogtagpki:master May 20, 2024
140 of 147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants