-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes changeset being empty when datetime change is sub second #2676
Conversation
(I do not have a local setup with mongo, so I'm sort of using the actions to test.. sorry about that) edit : I just saw that I can enable them in my fork, i'll test there :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the PHPCS fix and suppression.
if you know how to fix the style issue, feel free to fix it directly there if you want to save some time to restart the checks later ^^ Thanks ! |
It goes like this: mongodb-odm/lib/Doctrine/ODM/MongoDB/Tools/Console/Command/Schema/ValidateCommand.php Lines 44 to 45 in 8e0deb1
|
Thanks @magnetik! |
Summary
The ODM was ignoring changes when they are under a second (because of the cast as timestmap).
It might be a BC break because people can rely on the old behavior ?