Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to contribute deprecations #482

Merged
merged 1 commit into from
May 30, 2023
Merged

Document how to contribute deprecations #482

merged 1 commit into from
May 30, 2023

Conversation

greg0ire
Copy link
Member

See question 6 of #472

@mpdude please review

mpdude
mpdude approved these changes May 30, 2023
View reviewed changes
Copy link

@mpdude mpdude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine!

Optionally, include a remark that when something is deprecated in favor of a new API, that new API must be present in or added with the minor x.y.0 release that adds the deprecation?

@greg0ire
Copy link
Member Author

@mpdude addressed :)

@greg0ire greg0ire requested a review from SenseException May 30, 2023 19:53
@SenseException SenseException merged commit c4e44ad into doctrine:master May 30, 2023
@mpdude mpdude mentioned this pull request May 30, 2023
Open
@SenseException SenseException added the Improvement Improvement to the code base label May 30, 2023
@greg0ire greg0ire deleted the deprecations branch May 30, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpdude mpdude mpdude approved these changes

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
Improvement Improvement to the code base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greg0ire @SenseException @mpdude