fix: php drivers namespace #1794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
reviewed
Apr 17, 2024
config/orm.xml
Outdated
| @@ -33,8 +33,8 @@ | |||
| <parameter key="doctrine.orm.metadata.annotation.class">Doctrine\ORM\Mapping\Driver\AnnotationDriver</parameter> | |||
| <parameter key="doctrine.orm.metadata.xml.class">Doctrine\ORM\Mapping\Driver\SimplifiedXmlDriver</parameter> | |||
| <parameter key="doctrine.orm.metadata.yml.class">Doctrine\ORM\Mapping\Driver\SimplifiedYamlDriver</parameter> | |||
| <parameter key="doctrine.orm.metadata.php.class">Doctrine\ORM\Mapping\Driver\PHPDriver</parameter> | |||
| <parameter key="doctrine.orm.metadata.staticphp.class">Doctrine\ORM\Mapping\Driver\StaticPHPDriver</parameter> | |||
| <parameter key="doctrine.orm.metadata.php.class">Doctrine\ORM\Persistence\Driver\PHPDriver</parameter> | |||
There was a problem hiding this comment.
Shouldn't this be
Suggested change
| <parameter key="doctrine.orm.metadata.php.class">Doctrine\ORM\Persistence\Driver\PHPDriver</parameter> | |
| <parameter key="doctrine.orm.metadata.php.class">Doctrine\Persistence\Mapping\Driver\PHPDriver</parameter> |
?
There was a problem hiding this comment.
It seems correct according to the upgrade documentation https://github.com/doctrine/orm/blob/3.1.x/UPGRADE.md#metadata-drivers
There was a problem hiding this comment.
Actually you're right I made a typo nice catch! I did it well for StaticPHPDriver not for PHPDriver ✅
alexpozzi
approved these changes
Apr 17, 2024
update PHPDriver and StaticPHPDriver namespace to Doctrine/Persistence
stof
approved these changes
Apr 17, 2024
|
Dupe of #1755 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update PHPDriver and StaticPHPDriver namespace to Doctrine/Persistence.
Related to issue #1793